docs(pages): sync review-rules table with system_rules.json and add ru locale - #612
Open
nolanchic wants to merge 1 commit into
Open
docs(pages): sync review-rules table with system_rules.json and add ru locale#612nolanchic wants to merge 1 commit into
nolanchic wants to merge 1 commit into
Conversation
…u locale The "Rule resolution per file" table in en/ja/zh was missing 11 entries (go, astro, python, protobuf, po, pot, graphql, prisma, julia, terraform, bicep) that exist in internal/config/rules/system_rules.json. Rows are now ordered to match the declaration order in system_rules.json. Also adds pages/src/content/docs/ru/review-rules.md, translating the full page to Russian (the ru locale only had installation.md and quickstart.md so far) and registers it in the docs index so the ru site shows the translated page instead of the English fallback. Closes alibaba#608
|
|
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Rule resolution per file" table in
pages/src/content/docs/{en,ja,zh}/review-rules.mdwas missing 11 entries that are present ininternal/config/rules/system_rules.json:go,astro,python,protobuf,po,pot,graphql,prisma,julia,terraform,bicepThe rows are now ordered to match the declaration order in
system_rules.json.This also adds
pages/src/content/docs/ru/review-rules.md— a full Russian translation of the page. Therulocale (added in #596) previously only hadinstallation.mdandquickstart.md, so this fills in the next page. The new file is registered insrc/content/docs/index.tsso therudocs site renders the translated page rather than falling back to English.Type of Change
How Has This Been Tested?
Documentation-only change; no Go code touched.
make testpasses locallyRan the docs-site checks from the
pages/directory:Verified the table in all four locales now has 31 entries matching
system_rules.json'spath_rule_mapin declaration order.Checklist
go fmt,go vet)Will sign the CLA once the bot posts the link on this PR.
Related Issues
Closes #608