test(session):add comprehensive test coverage for resume.go - #590
Merged
lizhengfeng101 merged 1 commit intoJul 30, 2026
Merged
Conversation
add comprehensive test coverage for resume.go Add 34 focused tests for session/resume.go, which previously had no dedicated test file. Tests cover every exported and unexported function: - SessionFilePath: empty ID rejection, valid path construction - CompletedCount: nil state, empty items, populated items - Item: nil state, missing key, found key, defensive copy verification - ValidateOptions: nil/workspace/empty/missing mode rejection, mode mismatch, range match/mismatch, commit match/mismatch, unsupported mode - applyResumeLine: session_start, review_item_done (with NewPath fallback and empty fingerprint skip), review_item_reused, review_item_failed (removal + empty fingerprint), unknown type, invalid JSON - applySessionStart: RepoDir preservation/override, SessionID preservation, all fields set - copyLlmComments: nil input, empty slice, deep copy with mutation isolation - LoadResumeState: nonexistent file, empty file, multiple records round-trip, invalid JSON, fail-then-redo replay sequencing
Contributor
|
✅ OpenCodeReview: No supported files changed. |
StephenJarso
commented
Jul 29, 2026
StephenJarso
left a comment
Contributor
Author
There was a problem hiding this comment.
The tests are running and have followed the contribution guidelines
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add comprehensive test coverage for resume.go
Add 34 focused tests for session/resume.go, which previously had no dedicated test file. Tests cover every exported and unexported function:
Description
Type of Change
How Has This Been Tested?
make testpasses locallyChecklist
go fmt,go vet)Related Issues