fix: honor per-file review terminal states - #582
Open
4-1-1 wants to merge 1 commit into
Open
Conversation
|
|
Author
|
CLA Assistant confirms that I signed the CLA as 4-1-1. I rechecked the original PR #578 and recreated it as this PR (#582), but the |
Contributor
|
🔍 OpenCodeReview found 2 issue(s) in this PR.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
4-1-1
force-pushed
the
codex/fix-review-terminal-state
branch
from
July 30, 2026 02:54
80f5141 to
31596c9
Compare
Treat FAILED and missing completion as review failures, and retry invalid task_done states instead of accepting them as success. Keep partial scan output and session history aligned with those states.
4-1-1
force-pushed
the
codex/fix-review-terminal-state
branch
from
July 30, 2026 03:13
31596c9 to
2507df0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing