fix(vscode): support workspace review before first commit - #515
Merged
lizhengfeng101 merged 1 commit intoJul 27, 2026
Conversation
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
lizhengfeng101
requested review from
MuoDoo,
css521,
lizhengfeng101,
wbgbg and
xyJen
July 27, 2026 01:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Workspace review currently fails in a newly initialized Git repository before its first commit.
git diff --name-status HEADcannot resolve an unbornHEAD; because it runs insidePromise.all, the rejection also discards the successfully collected untracked files and clearsworkspaceFiles. As a result, the VS Code extension disables starting a review even when the repository contains staged or untracked changes.This change:
HEADdiff as unavailable and reuses the existing cached diff fallback;Type of Change
How Has This Been Tested?
make testpasses locallyAutomated checks:
yarn install --frozen-lockfileyarn lintyarn compileyarn buildThe full test run on Windows has one pre-existing failure in
CliService.isAvailablerelated to spawningnpm; this is unrelated to thischange and is being addressed by #490. The new regression test passes, and the
remaining 88 tests pass locally.
Checklist
Related Issues
N/A. Follow-up to #334.