feat(allowlist): add Protocol Buffers (.proto) support - #473
Merged
lizhengfeng101 merged 1 commit intoJul 30, 2026
Conversation
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
Collaborator
ReviewThe proto support itself looks good — clean changes, well-structured rule doc, and solid test coverage. Happy to see this land as part of #470. However, this PR includes two unrelated CI changes that should be removed: 1.
|
chethanuk
force-pushed
the
fix/issue-470-featallowlist-expand-supported-file-types-language
branch
2 times, most recently
from
July 30, 2026 08:29
579bd4f to
ef1e76f
Compare
14 tasks
Allow .proto files through the extension allowlist and map them to a dedicated protobuf review rule focused on wire compatibility. Part of alibaba#470.
chethanuk
force-pushed
the
fix/issue-470-featallowlist-expand-supported-file-types-language
branch
from
July 30, 2026 08:44
ef1e76f to
caeeaa5
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Protocol Buffers as the first language-group contribution for tracking issue #470.
.protofiles were skipped by both review paths because they were missing from the extension allowlist. This PR:.proto/.PROTOviasupported_file_types.json**/*.proto→ a dedicatedprotobuf.mdrule doc (wire compatibility focus)No Go source changes. No exclude patterns (proto has no standard test-file convention per #470).
Why this was needed
After this PR:
Changes
internal/config/allowlist/supported_file_types.json.protointernal/config/allowlist/allowed_ext_test.goIsAllowedExtcases for.proto/.PROTOinternal/config/rules/system_rules.json"**/*.proto": "protobuf.md"internal/config/rules/rule_docs/protobuf.mdinternal/config/rules/system_rules_test.go.protopathsRule doc focus
optional, map/repeated, oneof)Any/ unbounded payloads / secrets in defaultsTest plan
go test -run 'TestIsAllowedExt|TestResolve_DefaultRules' ./internal/config/allowlist/ ./internal/config/rules/go test ./internal/config/...make checkmake testgrep -l "Wire Compatibility" rule_docs/*→ onlyprotobuf.mdOut of scope
.vambiguity, …).tfPart of #470.