Fix VLM position_ids packing in Megatron strategy with sequence packing enabled#452
Open
sanmuf wants to merge 1 commit into
Open
Fix VLM position_ids packing in Megatron strategy with sequence packing enabled#452sanmuf wants to merge 1 commit into
sanmuf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Megatron VLM sequence packing by packing 3D mRoPE
position_idstogether withinput_ids.Details
For Qwen2-VL / Qwen3-VL style VLM models,
position_idsare 3D mRoPE tensors. Previously, whensequence_packingwas enabled, only token tensors such asinput_idsandlabelswere packed, while VLMposition_idsremained unpacked.This caused packed token sequences and mRoPE position ids to have inconsistent shapes, leading to Megatron RoPE runtime errors during reference/train forward:
This happens in Megatron's RoPE application path:
Changes
Pack position_ids together with input_ids when sequence_packing is enabled.
Adjust padding logic in _pack_sequences to support non-1D tensors such as VLM position ids.
For non-packing mode, preserve the existing VLM position id layout.
Validation
After this fix, VLM position_ids are packed consistently with tokens and the Megatron forward path no longer hits the RoPE shape mismatch.