Skip to content

Cleanup feature without Ruby code#4

Open
hsbt wants to merge 10 commits into
masterfrom
rmeoved-needless-files
Open

Cleanup feature without Ruby code#4
hsbt wants to merge 10 commits into
masterfrom
rmeoved-needless-files

Conversation

@hsbt

@hsbt hsbt commented Feb 19, 2019

Copy link
Copy Markdown
Collaborator

I added the feature of cleanup files without Ruby code. I removed the following files.

  • The vulnerable files detected by F-Secure Anti-Virus.
  • The files what used extension name without .rb, .rake and the majority of Ruby code.
  • The files that ruby -c raised error status.

I know this feature is slow down of rake unpack task.

@akr @mame How about this?

Comment thread Rakefile
}

File.open("payload.txt") do |f|
f.each_line do |i|

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe i.chomp! or something is needed.

@akr

akr commented Feb 19, 2019

Copy link
Copy Markdown
Owner

Is it remove C files?

@hsbt

hsbt commented Feb 19, 2019

Copy link
Copy Markdown
Collaborator Author

Is it remove C files?

Maybe, Yes. But I know we hope to search for C function usage like rb_*. Should we store files that are .c, .h, .cpp and .hpp ?

@hsbt

hsbt commented Feb 25, 2019

Copy link
Copy Markdown
Collaborator Author

@akr I also ignored C/C++ source files. Can I merge this?

@akr akr mentioned this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants