docs(readme): fix release badge to use GitHub releases, not raw tags - #2441
Merged
Conversation
github/v/tag pulls from all git tags, which include in-progress rc tags (e.g. 2.4.0-rc20a), so the badge could show an unreleased release candidate as "release". Switch to github/v/release, which only reflects actual GitHub Release objects; this repo's release workflow already skips creating a Release for pre-release versions, so this endpoint can never surface an rc. Pin sort=semver so a newer-dated patch release on a support/N.x branch doesn't outrank a higher-versioned release on the mainline.
Ports: b6e8c5f Partial port: support/1.x's fix (#2442) additionally scopes the badge to filter=1.* since that branch's README tracks the 1.x line specifically, while this branch's badge should reflect the repo's overall highest release. Same root fix (github/v/tag -> github/v/release + sort=semver), genuine content difference in the filter, so subject/patch matching won't bridge it -- add the merge-ignore entry so gitflow-changelog doesn't flag #2442 as an unported gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The README's "release" badge used
github/v/tag/aklivity/zilla, which reads from raw git tags. This repo's git-flow release process tags every version, including in-progress release candidates (e.g.2.4.0-rc1through2.4.0-rc20a), so the badge could show an unreleased rc as the "release" instead of the latest finished version.Switched to
github/v/release/aklivity/zilla, which reads from actual GitHub Release objects. This repo's release workflow already skips creating a Release for pre-release versions (confirmed: the repo's Releases list contains only realx.y.zversions, no rc's), so this endpoint structurally can't surface an unfinished rc. Also pinnedsort=semverexplicitly, since this repo releases patches onsupport/N.xbranches independently ofdevelop— a newer-dated patch release on an older support branch should not outrank a higher-versioned release on the mainline.Generated by Claude Code