feat(inventory): add CPU arch reporting and SDL arch attribute support - #337
feat(inventory): add CPU arch reporting and SDL arch attribute support#337chainzero wants to merge 3 commits into
Conversation
📝 WalkthroughWalkthroughThe PR adds an ChangesCPU arch propagation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go/sdl/cpu.go`:
- Around line 19-38: In v2ResourceCPU.UnmarshalYAML, validate that the incoming
yaml.Node is a mapping before iterating node.Content; currently scalar or
sequence nodes fall through and return an empty v2ResourceCPU without error. Add
an early node.Kind check in UnmarshalYAML and return a clear error for
non-mapping CPU resources, then keep the existing field decoding logic for units
and attributes unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f02118f0-e2f0-4126-b412-4b1dcd49212d
⛔ Files ignored due to path filters (1)
go/inventory/v1/cpu.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (4)
go/inventory/v1/cpu.gogo/sdl/cpu.gogo/sdl/cpu_test.goproto/provider/akash/inventory/v1/cpu.proto
📝 Description
Covers inventory CPU arch reporting, bid engine filtering, and SDL arch attribute support
🔧 Purpose of the Change
📌 Related Issues
✅ Checklist