Repository navigation
fix(deps): clear npm audit, and fail on any advisory a user would install - #168
Merged
Merged
Conversation
…tall - cli: @hono/node-server 2.1.6 (GHSA-rmxm-3fg6-px4f); overrides take minimatch to 11 and esbuild to 0.28 in the repo's own tree. - vscode: overrides for minimatch, glob, diff and serialize-javascript, all pulled in by vsce, mocha and test-cli. - security.yml: every package's lockfile must audit clean at any severity, vscode included. - check-package.mjs audits the packed tarball installed into an empty directory - what a user and an MCP directory's scanner get - and fails on any advisory not in scripts/audit-exceptions.json, or on an exception that no longer applies. The one exception is minimatch under @oclif/core: oclif's latest release still requires ^10.2.5, and neither overrides nor a shipped shrinkwrap reach a user's install (npm resolves a dependency's range afresh). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears
npm auditacross the repo, and makes CI fail on any advisory that someone installing SupaForge would get.What users install
Published 0.0.41, installed into an empty directory, had one moderate advisory: minimatch GHSA-g3hv-75wg-m249, pulled in by
@oclif/core.@oclif/core(5.1.11) still requiresminimatch ^10.2.5, and the fix is in 11.0.1. Upstream's bump is fix(deps): bump minimatch from 10.2.6 to 11.0.1 oclif/core#1664, open.overridesentry in our package.json only applies inside this repo, never to someone installing the package.npm-shrinkwrap.jsonholding minimatch 11 was tested: it lands in the tarball, but npm ignores the pinned version because 11 is outside oclif's range, and installs 10.2.6 anyway.So it is the single entry in
packages/cli/scripts/audit-exceptions.json, with the reason and when to remove it.Changes
check-package.mjsalready installs the packed tarball into an empty directory and runs it. Now it also audits that install:audit-exceptions.json.@hono/node-server2.1.6 for GHSA-rmxm-3fg6-px4f (moderate, via the MCP SDK).tscand all 1950 unit tests pass.vsce packagestill works.security.yml:npm audit: 0 vulnerabilities in cli, mcp and vscode.🤖 Generated with Claude Code