Repository navigation
corpus: a sequence filled by a trigger, and a default on a sequence its column does not own - #21
Merged
Merged
Conversation
…ts column does not own Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two migration cases for sequences that a column owns but no default uses. Both shapes come from GitLab's schema.
owned_sequence_filled_by_a_trigger: a trigger fills the id from a sequence the column owns, so the column has no default. A tool that reads this as the column's serial never creates the sequence, and the first insert fails.default_on_a_sequence_the_column_does_not_own: the id default draws on one sequence, while the column owns another that nothing uses. Writing the column as a serial makes the copy's default draw on the owned one.Checked with DBDiff's Corpus suite on PostgreSQL 18: all 4 runs (both directions of each case) fail on DBDiff master and pass with the DBDiff fix for these shapes. This package's own tests are unchanged: 44 tests, 0 failures.
🤖 Generated with Claude Code