[PR #13457/e54b79cb backport][3.15] Build the websocket reader_c extension without the reader_c.py symlink - #13469
Conversation
Confidence Score: 5/5The PR appears safe to merge, with no concrete build, runtime, packaging, or security failure identified. The changed build rule preserves the extension name expected by setup and imports, while the existing distribution pipeline generates the C source before packaging; no actionable regression remains. Reviews (1): Last reviewed commit: "Build the websocket reader_c extension w..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.15 #13469 +/- ##
==========================================
+ Coverage 95.66% 96.20% +0.54%
==========================================
Files 160 159 -1
Lines 51183 50894 -289
Branches 2828 2771 -57
==========================================
- Hits 48964 48963 -1
+ Misses 2039 1751 -288
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This is a backport of PR #13457 as merged into master (e54b79c).
What do these changes do?
Removes the
aiohttp/_websocket/reader_c.pysymlink; the extension is now compiled directly fromreader_py.pyusingcython --module-name aiohttp._websocket.reader_c. The symlink only existed so Cython would pair the source withreader_c.pxdand emit the right module name, but after #13388 the wheel build materializes it as a regular file in site-packages, which coverage then reports as a new 0% file.Are there changes in behavior for the user?
No runtime changes; dists no longer contain a stray
reader_c.pyfile,reader_conly exists as the compiled extension.Is it a substantial burden for the maintainers to support this?
No, it is one less special case; the Makefile rule is the only thing that changed.
Related issue number
Follow up to #13388
Checklist
CONTRIBUTORS.txtCHANGES/folder<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)Drafted with Claude Code; reviewed by bdraco.