Skip to content

[PR #13422/356d355b backport][3.15] 🧪 Sync coveragepy setup w/ other projects - #13423

Merged
webknjaz merged 1 commit into
aio-libs:3.15from
webknjaz:patchback/backports/3.15/356d355b7928ada4c2deb86e13992310b33d52f9/pr-13422/handcrafted-cherry-pick-by-webknjaz
Aug 15, 2026
Merged

[PR #13422/356d355b backport][3.15] 🧪 Sync coveragepy setup w/ other projects#13423
webknjaz merged 1 commit into
aio-libs:3.15from
webknjaz:patchback/backports/3.15/356d355b7928ada4c2deb86e13992310b33d52f9/pr-13422/handcrafted-cherry-pick-by-webknjaz

Conversation

@webknjaz

Copy link
Copy Markdown
Member

This is a backport of PR #13422 as merged into master (356d355).

@webknjaz
webknjaz requested a review from asvetlov as a code owner August 14, 2026 23:54
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Aug 14, 2026
@webknjaz
webknjaz enabled auto-merge (squash) August 14, 2026 23:55
@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking environment-ordering issue that can undermine the Autobahn parallel-mode override in externally configured test environments.

The existing CI does not define the conflicting environment variable and the coverage artifact paths remain consistent, but both Autobahn subprocess environments allow an inherited value to replace the explicit false setting.

Files Needing Attention: tests/autobahn/test_autobahn.py

Reviews (1): Last reviewed commit: "[PR #13422/356d355b backport][3.15] 🧪 S..." | Re-trigger Greptile

Comment on lines +88 to +91
env={
"COVERAGE_PARALLEL_MODE": "false",
**os.environ.copy(),
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Inherited environment overrides opt-out

If the parent environment defines COVERAGE_PARALLEL_MODE=true, expanding os.environ after the explicit false value replaces the intended opt-out in both Autobahn subprocesses, allowing coverage run --append to use incompatible parallel collection. Reverse the mapping order so the explicit value always wins.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (3b61410) to head (54c6178).
⚠️ Report is 8 commits behind head on 3.15.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.15   #13423      +/-   ##
==========================================
- Coverage   98.28%   96.20%   -2.09%     
==========================================
  Files         136      159      +23     
  Lines       49713    50895    +1182     
  Branches     2682     2772      +90     
==========================================
+ Hits        48861    48964     +103     
- Misses        672     1751    +1079     
  Partials      180      180              
Flag Coverage Δ
CI-GHA 96.17% <100.00%> (-2.11%) ⬇️
OS-Linux 95.96% <100.00%> (-2.11%) ⬇️
OS-Windows 93.68% <100.00%> (-2.06%) ⬇️
OS-macOS 95.13% <100.00%> (-2.11%) ⬇️
Py-3.10 95.31% <100.00%> (-2.10%) ⬇️
Py-3.11 95.58% <100.00%> (-2.11%) ⬇️
Py-3.12 95.66% <100.00%> (-2.11%) ⬇️
Py-3.13 95.65% <100.00%> (-2.10%) ⬇️
Py-3.14 95.75% <100.00%> (-2.11%) ⬇️
Py-3.14t 94.76% <100.00%> (-2.09%) ⬇️
Py-pypy-3.11 94.61% <100.00%> (-2.07%) ⬇️
VM-macos 95.13% <100.00%> (-2.11%) ⬇️
VM-ubuntu 95.96% <100.00%> (-2.11%) ⬇️
VM-windows 93.68% <100.00%> (-2.06%) ⬇️
cython-coverage 78.04% <ø> (+39.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 15, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 9.08%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 83 untouched benchmarks
⏩ 86 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
test_simple_web_file_response[ssl-large-pyloop] 305.5 ms 280.1 ms +9.08%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing webknjaz:patchback/backports/3.15/356d355b7928ada4c2deb86e13992310b33d52f9/pr-13422/handcrafted-cherry-pick-by-webknjaz (54c6178) with 3.15 (94209dc)2

Open in CodSpeed

Footnotes

  1. 86 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on 3.15 (0f4084b) during the generation of this report, so 94209dc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@webknjaz
webknjaz merged commit e0273a5 into aio-libs:3.15 Aug 15, 2026
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant