[PR #13422/356d355b backport][3.15] 🧪 Sync coveragepy setup w/ other projects - #13423
Conversation
…/ other projects (cherry picked from commit 356d355)
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking environment-ordering issue that can undermine the Autobahn parallel-mode override in externally configured test environments. The existing CI does not define the conflicting environment variable and the coverage artifact paths remain consistent, but both Autobahn subprocess environments allow an inherited value to replace the explicit false setting. Files Needing Attention: tests/autobahn/test_autobahn.py Reviews (1): Last reviewed commit: "[PR #13422/356d355b backport][3.15] 🧪 S..." | Re-trigger Greptile |
| env={ | ||
| "COVERAGE_PARALLEL_MODE": "false", | ||
| **os.environ.copy(), | ||
| }, |
There was a problem hiding this comment.
Inherited environment overrides opt-out
If the parent environment defines COVERAGE_PARALLEL_MODE=true, expanding os.environ after the explicit false value replaces the intended opt-out in both Autobahn subprocesses, allowing coverage run --append to use incompatible parallel collection. Reverse the mapping order so the explicit value always wins.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.15 #13423 +/- ##
==========================================
- Coverage 98.28% 96.20% -2.09%
==========================================
Files 136 159 +23
Lines 49713 50895 +1182
Branches 2682 2772 +90
==========================================
+ Hits 48861 48964 +103
- Misses 672 1751 +1079
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Merging this PR will improve performance by 9.08%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_simple_web_file_response[ssl-large-pyloop] |
305.5 ms | 280.1 ms | +9.08% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing webknjaz:patchback/backports/3.15/356d355b7928ada4c2deb86e13992310b33d52f9/pr-13422/handcrafted-cherry-pick-by-webknjaz (54c6178) with 3.15 (94209dc)2
Footnotes
-
86 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
3.15(0f4084b) during the generation of this report, so 94209dc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
This is a backport of PR #13422 as merged into master (356d355).