Skip to content

[PR #13388/203c1c59 backport][3.14] 🧪 Run tests from sdist like downstreams - #13414

Merged
webknjaz merged 2 commits into
aio-libs:3.14from
webknjaz:patchback/backports/3.14/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz
Aug 17, 2026
Merged

[PR #13388/203c1c59 backport][3.14] 🧪 Run tests from sdist like downstreams#13414
webknjaz merged 2 commits into
aio-libs:3.14from
webknjaz:patchback/backports/3.14/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz

Conversation

@webknjaz

@webknjaz webknjaz commented Aug 14, 2026

Copy link
Copy Markdown
Member

This is a backport of PR #13388 as merged into master (203c1c5). It also includes a backport of a follow-up PR #13430 (7dc43ae).

@webknjaz
webknjaz requested a review from Dreamsorcerer August 14, 2026 00:08
@webknjaz
webknjaz requested a review from asvetlov as a code owner August 14, 2026 00:08
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Aug 14, 2026
@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (3): Last reviewed commit: "[PR #13388/203c1c59 backport][3.14] 🧪 R..." | Re-trigger Greptile

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.63%. Comparing base (cda240d) to head (2147919).
⚠️ Report is 4 commits behind head on 3.14.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.14   #13414      +/-   ##
==========================================
- Coverage   96.17%   95.63%   -0.55%     
==========================================
  Files         158      159       +1     
  Lines       50564    50852     +288     
  Branches     2735     2791      +56     
==========================================
+ Hits        48630    48631       +1     
- Misses       1754     2042     +288     
+ Partials      180      179       -1     
Flag Coverage Δ
CI-GHA 95.63% <100.00%> (-0.56%) ⬇️
OS-Linux 95.42% <100.00%> (-0.56%) ⬇️
OS-Windows 93.16% <100.00%> (-0.54%) ⬇️
OS-macOS 94.62% <100.00%> (-0.55%) ⬇️
Py-3.10 94.81% <100.00%> (-0.55%) ⬇️
Py-3.11 95.08% <100.00%> (-0.56%) ⬇️
Py-3.12 95.16% <100.00%> (-0.56%) ⬇️
Py-3.13 95.15% <100.00%> (-0.56%) ⬇️
Py-3.14 95.25% <100.00%> (-0.55%) ⬇️
Py-3.14t 94.26% <100.00%> (-0.55%) ⬇️
Py-pypy-3.11 94.10% <100.00%> (-0.54%) ⬇️
VM-macos 94.62% <100.00%> (-0.55%) ⬇️
VM-ubuntu 95.42% <100.00%> (-0.56%) ⬇️
VM-windows 93.16% <100.00%> (-0.54%) ⬇️
cython-coverage 78.15% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing webknjaz:patchback/backports/3.14/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz (2147919) with 3.14 (cda240d)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@webknjaz webknjaz added the infra label Aug 14, 2026
… branch directory skip

PR 13388 introduced partial branch coverage in a directory scan skip
logic in `tests/test_circular_imports.py::test_no_warnings`. This patch
is attempting to address is by bringing the coverage on the test module
back to 100% metric via an explicitly applied "no branch" pragma.

The missing branch coverage only appears in test environments checking
real project installs that are non-editable. Editable installs have a
`aiohttp/.hash/` cache directory that would contain files like
`_http_parser.pyx.hash`, `_cparser.pxd.hash`, `hdrs.py.hash`,
`_find_header.pxd.hash` and `_http_writer.pyx.hash` which speed up
processes in local development environment. The `continue` instruction
would only be hit there.

(cherry picked from commit 7dc43ae)
@webknjaz
webknjaz force-pushed the patchback/backports/3.14/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz branch from cac7c7f to 931044e Compare August 16, 2026 21:55
…ke downstreams

Merge PR aio-libs#13388 from branch 'testing/wheel-ci-cd-from-sdist'

(cherry picked from commit 203c1c5)
@webknjaz
webknjaz force-pushed the patchback/backports/3.14/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz branch from 931044e to 2147919 Compare August 17, 2026 13:35
@webknjaz

Copy link
Copy Markdown
Member Author

pre-commit.ci run

@webknjaz
webknjaz merged commit 3bb6e7b into aio-libs:3.14 Aug 17, 2026
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants