[PR #13388/203c1c59 backport][3.14] 🧪 Run tests from sdist like downstreams - #13414
Conversation
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (3): Last reviewed commit: "[PR #13388/203c1c59 backport][3.14] 🧪 R..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.14 #13414 +/- ##
==========================================
- Coverage 96.17% 95.63% -0.55%
==========================================
Files 158 159 +1
Lines 50564 50852 +288
Branches 2735 2791 +56
==========================================
+ Hits 48630 48631 +1
- Misses 1754 2042 +288
+ Partials 180 179 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Merging this PR will not alter performance
Comparing Footnotes
|
… branch directory skip PR 13388 introduced partial branch coverage in a directory scan skip logic in `tests/test_circular_imports.py::test_no_warnings`. This patch is attempting to address is by bringing the coverage on the test module back to 100% metric via an explicitly applied "no branch" pragma. The missing branch coverage only appears in test environments checking real project installs that are non-editable. Editable installs have a `aiohttp/.hash/` cache directory that would contain files like `_http_parser.pyx.hash`, `_cparser.pxd.hash`, `hdrs.py.hash`, `_find_header.pxd.hash` and `_http_writer.pyx.hash` which speed up processes in local development environment. The `continue` instruction would only be hit there. (cherry picked from commit 7dc43ae)
cac7c7f to
931044e
Compare
…ke downstreams Merge PR aio-libs#13388 from branch 'testing/wheel-ci-cd-from-sdist' (cherry picked from commit 203c1c5)
931044e to
2147919
Compare
|
pre-commit.ci run |
This is a backport of PR #13388 as merged into master (203c1c5). It also includes a backport of a follow-up PR #13430 (7dc43ae).