Add configurable save directory for Autofill-saved entries - #1035
Open
AuthenticSm1les wants to merge 1 commit into
Open
Add configurable save directory for Autofill-saved entries#1035AuthenticSm1les wants to merge 1 commit into
AuthenticSm1les wants to merge 1 commit into
Conversation
Credentials saved via the Autofill framework (the system "Save to Password Store?" prompt shown while the app is closed) were always written directly to the repository root, with no way to route them into a category subfolder like a user-organized store might use. Add a "Save directory" setting under Settings > Autofill that lets users specify a root subfolder; Autofill-originated saves are then resolved under that folder instead of the store root. Leaving it unset preserves the existing behavior exactly. The in-app "+" entry creation flow is unaffected in every case. Fixes pando85#127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutofillPreferences.saveDirectory()) that lets users specify a root subfolder (e.g.www); Autofill-originated saves are then resolved under that folder instead of the store root.AutofillSaveActivity) — leaving it unset preserves existing behavior exactly, and the in-app "+" entry creation flow is unaffected in every case.Test plan
./gradlew :app:compileDebugKotlin— builds clean againstdevelopwww, trigger an Autofill save prompt on a new site, confirm the entry lands atwww/<site>/<file>instead of the store root