fix: correct clock ownership and LRU recency - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Previously, memoize.New created a 1 ms ticker before applying options. Injecting another clock replaced the reference but left the default ticker goroutine running. Invalid cache construction could also leave that ticker behind. Cache.Stop then stopped the injected ticker instead of the hidden default ticker.
The memory fast path also returned fresh values without updating recency. A frequently read key could therefore be evicted even though memory.New documents exact LRU behavior.
The first CI run also exposed that the workflow used Go 1.25.10, whose standard library is affected by vulnerabilities fixed in Go 1.25.13. The tests were already passing; govulncheck was the failing step.
Behavior after this change
Validation