fix: debug trace bridge call matching#1608
Merged
arnaubennassar merged 4 commits intorelease/0.8from Apr 29, 2026
Merged
Conversation
- Filter debug trace call matching to actual `CALL` frames in `bridgesync` and `claimsync`, avoiding calldata extraction from `DELEGATECALL`, `STATICCALL`, `CALLCODE`, or missing-type frames. - Add call tracer frame type constants and include the `type` field in decoded trace calls. - Make claim calldata extraction reject ambiguous distinct matching bridge calls while accepting duplicate identical matches. - Extend bridge and claim sync tests for call-frame filtering, ambiguous calldata, and updated mocked debug traces. - 🛠️ **Config**: None - 🔌 **API/CLI**: None - 🗑️ **Deprecated Features**: None - 🧾 **Diff/Config snippet**: None - 🤖 **Automatic**: `go test ./bridgesync ./claimsync` - 🖱️ **Manual**: Not run - None - None - The fix keeps debug trace traversal behavior but only treats canonical `CALL` frames to the bridge as extraction candidates, preventing delegate-call calldata from being selected as if it were a direct bridge call.
joanestebanr
approved these changes
Apr 29, 2026
arnaubennassar
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Changes Summary
5e75ba1a(fix: debug trace bridge call matching (#1605)) torelease/0.8.CALLframes inbridgesync, avoiding calldata extraction fromDELEGATECALL,STATICCALL,CALLCODE, or missing-type frames.typefield in decoded trace calls.bridgesynctests for call-frame filtering and mocked debug traces.📋 Config Updates
✅ Testing
go test ./bridgesync -run 'TestFindCall|TestBackfillTxnSender|TestClaimCalldata' -count=1\n- 🤖 Automatic:go test ./bridgesyncwas also run, but failed on therelease/0.8branch after a long package run; the relevant touched tests above passed.\n- 🖱️ Manual: Not run\n\n## 🐞 Issues\n- None\n\n## 🔗 Related PRs\n- Backport of fix: debug trace bridge call matching #1605\n\n## 📝 Notes\n-claimsyncchanges from the original squash commit are not present in this backport becauserelease/0.8does not contain theclaimsyncdownloader files changed by fix: debug trace bridge call matching #1605.