Skip to content

fix(config): reject non-positive explorer_sync_interval / trainer_sync_interval #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Linxiushen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(config): reject non-positive explorer_sync_interval / trainer_sync_interval #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/common/config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,16 @@ def test_multinode_vllm_requires_full_node_occupancy(self):
with self.assertRaisesRegex(ValueError, "to be a multiple of"):
config.check_and_update()

def test_sync_interval_overrides_must_be_positive(self):
for field in ("explorer_sync_interval", "trainer_sync_interval"):
with self.subTest(field=field):
config = get_template_config()
config.synchronizer.sync_interval = 4
setattr(config.synchronizer, field, 0)

with self.assertRaisesRegex(AssertionError, f"`{field}` must be positive"):
config.check_and_update()

def test_load_default_config(self):
config = get_template_config()
config.buffer.batch_size = 8
Expand Down
6 changes: 6 additions & 0 deletions trinity/common/config_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,6 +868,12 @@ def validate(self, config: Config) -> None:
config.synchronizer, "explorer_sync_interval", config.synchronizer.sync_interval
)
set_if_none(config.synchronizer, "trainer_sync_interval", config.synchronizer.sync_interval)
assert (
config.synchronizer.explorer_sync_interval > 0
), "`explorer_sync_interval` must be positive."
assert (
config.synchronizer.trainer_sync_interval > 0
), "`trainer_sync_interval` must be positive."


class IntervalConfigValidator(ConfigValidator):
Expand Down