fix: surface workspace, origin, and browser-init in hosted help - #464
Merged
Conversation
Expose --workspace/WEBCMD_WORKSPACE, list site/session at the root, point missing site commands at browser init, and show list origin.
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
Reserved roots now follow WEBCMD_ROOT_COMMANDS plus hosted root help. List origin uses builtin/plugin/local/override strings, not a second vocabulary.
Released 0.7.9 rejects extra command.origin. Request the field only when this client can parse it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Hosted help hid workspace/session/site, unknown site commands omitted
browser init, and list origin used a second vocabulary. Packed 0.7.9 also cannot parsecommand.originunless Cloud gates it.Contract
--workspace <id>(alsoWEBCMD_WORKSPACE),session, andsite.To author this command: webcmd browser init <site>/<command>.WEBCMD_ROOT_COMMANDSplus hosted root-help names (tabis not reserved).formatCommandOrigin:builtin,plugin:<name>,local,override:<plugin>.hosted-command-origin-v1onx-webcmd-client-capabilitiesso Cloud can includeorigin. Released 0.7.9 does not send that token.Cross-repo
Depends on webcmd-cloud#80 to emit
originonly for capable clients. Until that ships, this CLI still acceptsoriginwhen present and fillsbuiltinfor the default/client-owned package.Tests
npx vitest run src/hosted/core-commands.test.ts src/hosted/client.test.ts src/hosted/manifest.test.ts— 178 passed.Does not merge.