feat(browser): support custom Chromium binary path - #462
Open
rishabhraj36 wants to merge 2 commits into
Open
Conversation
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional WEBCMD_BROWSER_BINARY_PATH environment override for compatible Chromium executables. The Webcmd-owned variable takes precedence over the existing CLOAKBROWSER_BINARY_PATH variable, while the managed Cloak browser remains the unchanged default when neither is set.
The override is forwarded to persistent Playwright launches and mirrored into CloakBrowser configuration so managed binary resolution and downloads are skipped. On macOS, custom executables use the normal Playwright persistent launcher because third-party app bundles may not implement the managed browser background-CDP contract. Doctor validates and reports the effective override.
Related issue: none
Type of Change
Checklist
Adapter Notes
Verification
The full unit/plugin suite passed 6,265 tests and had five unrelated existing DNS-policy failures in src/fetch/safe-proxy.test.ts under local Node 26.7.0.