Fix setup skill frontmatter validation and add testing milestone - #3
Open
oreganoflakesgit wants to merge 2 commits into
Open
Fix setup skill frontmatter validation and add testing milestone#3oreganoflakesgit wants to merge 2 commits into
oreganoflakesgit wants to merge 2 commits into
Conversation
Contributor
|
thanks for reporting this and providing a fix, will take a look tomorrow, appreciate the help |
ajmeese7
approved these changes
Feb 22, 2026
ajmeese7
left a comment
ajmeese7
left a comment
There was a problem hiding this comment.
Looks good to me -- syntax is solid, no new vulns // malicious code.
crichalchemist
referenced
this pull request
in crichalchemist/arscontexta
Aug 4, 2026
Three fixes from the whole-branch review, all of them this branch's own defect class landing in its own artifacts. The plan shipped 35 checkboxes with 0 ticked while all seven tasks were executed and reviewed -- the same "status file that lies" shape that CONTRIBUTING.md warns about two sections above, and that CLAUDE.md D5's published box-count loop would have surfaced at 0/35. Now 35/35. Deferral #3 said "Task 2's title says atomic". Task 2 is D6, the matcher; the atomic one is Task 5, which closes D2. The divergence number and the plan task number are different sequences and this conflated them. CONTRIBUTING.md contradicted itself 33 lines apart, and the review did not catch this one: :215 says ledgers under `.superpowers/sdd/` are git-ignored and "never the record", while :248 offered "delete the checkboxes and point at the ledger" as a valid remedy. Taking that arm would reintroduce D10 -- the defect Task 7 just closed -- while appearing to follow the guidance. It now points at a tracked record, quotes the old wording, and says why a remedy that routes a record somewhere it cannot ship is not a remedy. Ticking a box means the step was executed. Where the outcome was a measured rejection rather than a change -- Step 2.2's commit-message gate, declined on 1 true positive against 2 false positives -- the rejection and its measurement are recorded in the file the step names. That is stated in CONTRIBUTING.md rather than left for a reader to infer from a tick. Gates: 6 suites x both shells rc=0, portability rc=0, prose-paths 187/0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2