Skip to content

perf(sdk): import only the semver functions the ESM loader uses #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frontegg-david merged 1 commit into from
Oct 21, 2026
Merged

perf(sdk): import only the semver functions the ESM loader uses #925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions libs/sdk/src/esm-loader/semver.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@
* Isolates the semver dependency to a single file for easier maintenance.
*/

import * as semver from 'semver';
import semverCompare from 'semver/functions/compare.js';
import semverGt from 'semver/functions/gt.js';
import semverRcompare from 'semver/functions/rcompare.js';
import semverSatisfies from 'semver/functions/satisfies.js';
import semverValid from 'semver/functions/valid.js';
import semverMaxSatisfying from 'semver/ranges/max-satisfying.js';
import semverValidRange from 'semver/ranges/valid.js';

/**
* Check if a range string is a dist-tag (not a semver range).
Expand All @@ -14,7 +20,7 @@ import * as semver from 'semver';
* must be guarded separately before calling this function.
*/
function isDistTag(range: string): boolean {
return /^[a-zA-Z][a-zA-Z0-9]*$/.test(range) && semver.validRange(range) === null;
return /^[a-zA-Z][a-zA-Z0-9]*$/.test(range) && semverValidRange(range) === null;
}

/**
Expand All @@ -26,7 +32,7 @@ function isDistTag(range: string): boolean {
*/
export function satisfiesRange(version: string, range: string): boolean {
if (range === 'latest' || isDistTag(range)) return true;
return semver.satisfies(version, range);
return semverSatisfies(version, range);
}

/**
Expand All @@ -38,25 +44,25 @@ export function satisfiesRange(version: string, range: string): boolean {
*/
export function maxSatisfying(versions: string[], range: string): string | null {
if (range === 'latest' || isDistTag(range)) {
const sorted = versions.filter((v) => semver.valid(v)).sort(semver.rcompare);
const sorted = versions.filter((v) => semverValid(v)).sort(semverRcompare);
return sorted[0] ?? null;
}
return semver.maxSatisfying(versions, range);
return semverMaxSatisfying(versions, range);
}

/**
* Check if a string is a valid semver range.
*/
export function isValidRange(range: string): boolean {
if (range === 'latest' || isDistTag(range)) return true;
return semver.validRange(range) !== null;
return semverValidRange(range) !== null;
}

/**
* Check if a string is a valid semver version.
*/
export function isValidVersion(version: string): boolean {
return semver.valid(version) !== null;
return semverValid(version) !== null;
}

/**
Expand All @@ -66,12 +72,12 @@ export function isValidVersion(version: string): boolean {
* - positive if v1 > v2
*/
export function compareVersions(v1: string, v2: string): number {
return semver.compare(v1, v2);
return semverCompare(v1, v2);
}

/**
* Check if v1 is greater than v2.
*/
export function isNewerVersion(v1: string, v2: string): boolean {
return semver.gt(v1, v2);
return semverGt(v1, v2);
}
Loading