You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(e2e): the persistent-questions session ends with the token that opened it - #1144
The pre-release E2E gate of Publish Release failed on persistent-questions.e2e.spec.ts › "keeps an answer for the next session when the waiting session ends" (run 42081062660). It also failed twice on #1141, and passed elsewhere.
The test ends its MCP session with a DELETE, but it signed the DELETE with a token minted then, not the one the session was opened with. A streamable-HTTP session id is bound to the signature of the token that created it (authSig). TestTokenFactory tokens have no jti and second-resolution iat/exp, so the two tokens were byte-identical only when both were minted in the same second. When the test crossed a second boundary, session:verify didn't verify the session id and the DELETE answered 404.
The test now opens the session with a token it keeps, and ends it with that token. The server is unchanged: a session id is honored only for the token that opened it.
Tests
With a 1.1 s wait added before the DELETE, the old test fails every time (404) and the fixed one passes.
persistent-questions.e2e.spec.ts passes locally (the frontmcp inbox case needs the CLI build and runs in CI).
Summary by CodeRabbit
Tests
Updated end-to-end session coverage to use the same authentication token when connecting to and ending a session. This change affects test behavior only; no user-facing functionality has changed.
No actionable comments were generated in the recent review.
Walkthrough
The connect helper now delegates to connectWithToken, which accepts a pre-created token. The session-ending test uses the same Alice token to open the session and send the ending request.
Changes: E2E session token reuse
Layer / File(s)
Summary
Connection helper and session-ending test apps/e2e/demo-e2e-elicitation/e2e/persistent-questions.e2e.spec.ts
connect delegates connection setup to connectWithToken. The session-ending test reuses Alice’s opening token for the ending request.
The test now uses the session’s original token when ending it. No merge-blocking risk is established.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the change: the persistent-questions E2E test now ends its session with the token that opened it. The raw summary confirms the test now reuses the original token for connecting and del…
Description check
The description explains the failure on the persistent-questions E2E test. It gives the cause: a session id is bound to the signature of the token that opened it, and tokens minted in different second…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the change: the persistent-questions E2E test now ends its session with the token that opened it. The raw summary confirms the test now reuses the original token for connecting and deleting the session, so the title matches the main change. It is specific and fits the test(e2e) convention.
Full details: Description check
Explanation
The description explains the failure on the persistent-questions E2E test. It gives the cause: a session id is bound to the signature of the token that opened it, and tokens minted in different seconds differ. It states the fix, which opens and ends the session with one kept token, and that the server is unchanged. The Tests section lists a reproduction with a 1.1 s wait and local test results. The template's 'What and why' and 'Tests' sections are filled in. The 'User-facing change' section is omitted, which is correct because the change is test-only. The description does not mention the issue it closes, but the template asks for it only 'if any'.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 0 remain after this review.
Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
…e token that opened it (#1145)
Cherry-picked from #1144 (merged to release/1.11.x)
Original commit: f502e5a
Co-authored-by: agentfront[bot] <agentfront[bot]@users.noreply.github.com>
Co-authored-by: frontegg-david <69419539+frontegg-david@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![agentfront[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
What and why
The pre-release E2E gate of Publish Release failed on
persistent-questions.e2e.spec.ts› "keeps an answer for the next session when the waiting session ends" (run 42081062660). It also failed twice on #1141, and passed elsewhere.The test ends its MCP session with a DELETE, but it signed the DELETE with a token minted then, not the one the session was opened with. A streamable-HTTP session id is bound to the signature of the token that created it (
authSig).TestTokenFactorytokens have nojtiand second-resolutioniat/exp, so the two tokens were byte-identical only when both were minted in the same second. When the test crossed a second boundary,session:verifydidn't verify the session id and the DELETE answered 404.The test now opens the session with a token it keeps, and ends it with that token. The server is unchanged: a session id is honored only for the token that opened it.
Tests
persistent-questions.e2e.spec.tspasses locally (thefrontmcp inboxcase needs the CLI build and runs in CI).Summary by CodeRabbit