feat: a missing GitHub App installation gets the install link, not a console page - #5
Closed
spacedragon wants to merge 1 commit into
Closed
spacedragon wants to merge 1 commit into
spacedragon wants to merge 1 commit into
Conversation
…console page When listGithubInstallations shows nothing covering the repository's owner, the code-reviewer template now calls the admin MCP's getGithubApp and hands the user its installUrl verbatim: the org-bound, single-use, ~15-minute link GitHub needs to bind the installation to this organization. It spells out the 403 (viewer cannot mint) and tool-absent (older Control Plane) fallbacks, and forbids hand-building the github.com/apps/<slug> URL, which would lack the signed state. The platform skill's tool catalog gains the same row. Pairs with agentconnect-md/agentconnect: the getGithubApp MCP read tool. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the create-agent flow (code-reviewer template) finds no GitHub App installation covering the repository's owner, it now outputs the actual install URL instead of directing the user to a console page.
references/templates/code-reviewer.mdP1: call the admin MCP's newgetGithubAppand hand the user itsinstallUrlverbatim, with a one-line explanation (bound to this org, single-use, valid ~15 minutes, GitHub returns them to the console). Offer to wait via a URL-mode card, then re-runlistGithubInstallationsand continue. Spells out the fallbacks: 403 → an editor/owner must open the link; tool absent (older Control Plane) → the console's Workspace → GitHub editor shows the same link. Forbids hand-buildinggithub.com/apps/<slug>/installations/new, which lacks the signedstatethe setup callback requires.SKILL.md:getGithubAppjoins the tool list and the prerequisite step.agentconnect-platform/references/admin-operations.md: catalog row forgetGithubApp.The rest of the diff is Prettier re-padding two tables.
Why
Seen in a webchat session: with the App not yet installed, the agent could only point at a console tab, because no admin tool returned the install link. The link is minted per call with a signed org-bound state, so the skill cannot construct it; it needs the tool.
Depends on
agentconnect-md/agentconnect PR adding the
getGithubAppMCP read tool (GET /github/app). Until that ships, the skill's documented fallback (console Workspace → GitHub) applies.🤖 Generated with Claude Code