Skip to content

fix: mark ripgrep no-match as completed - #535

Open
kocaemre wants to merge 1 commit into
agentclientprotocol:mainfrom
kocaemre:fix/rg-no-match-status-refresh
Open

kocaemre wants to merge 1 commit into
agentclientprotocol:mainfrom
kocaemre:fix/rg-no-match-status-refresh

Conversation

@kocaemre

Copy link
Copy Markdown

Summary

  • Treat standalone rg/ripgrep commands that exit 1 with no output as completed ACP tool calls instead of failures.
  • Reuse the status mapping for both live command completion events and session-history replay.
  • Keep diagnostics, exit code 2, and compound shell commands as failures.

Closes #468.

Test Plan

  • npm test -- src/__tests__/CodexACPAgent/command-execution-status.test.ts
  • npm run typecheck
  • npm run build
  • npm test
  • git diff --check

Replaces #497: the original PR head stopped tracking the fork branch after the rebase, so this fresh branch carries the same focused fix rebased onto current main.

Additional refresh verification:

  • npm ci pass
  • npm test -- src/__tests__/CodexACPAgent/command-execution-status.test.ts pass (3 tests)
  • npm run typecheck pass
  • git diff --check origin/main..HEAD pass

Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ripgrep no-match exit code 1 is translated into an ACP failed tool call

1 participant