fix: prefer terminal output deltas - #528
Merged
nikita-ashihmin merged 1 commit intoSep 22, 2026
Merged
nikita-ashihmin merged 1 commit into
nikita-ashihmin merged 1 commit into
Conversation
Use explicit terminal output deltas when the client supports them. Avoid a duplicate full live output snapshot after streamed command output.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The capability negotiation, live event behavior, history preservation, and regression coverage are consistent with the stated goal.
Review effort: Balanced
Findings: None
What changed in this PR
Updates terminal output negotiation to prefer delta streaming while preserving complete output during history replay.
Changes:
- Prefer explicitly advertised
terminal_output_delta. - Avoid duplicate completion output in
rawOutput. - Add coverage and snapshots for delta-only completion behavior.
| File | Description |
|---|---|
src/TerminalOutputMode.ts |
Adds delta capability detection and precedence. |
src/CodexEventHandler.ts |
Prevents duplicate live command output. |
src/CodexAcpServer.ts |
Propagates negotiated delta support into sessions. |
src/__tests__/TerminalOutputMode.test.ts |
Tests mode precedence. |
src/__tests__/CodexACPAgent/terminal-output-events.test.ts |
Tests delta-only completion flows. |
src/__tests__/CodexACPAgent/data/terminal-full-flow.json |
Updates streamed-output snapshot. |
src/__tests__/CodexACPAgent/data/terminal-command-completed.json |
Updates completion fallback snapshot. |
src/__tests__/acp-test-utils.ts |
Adds the capability default to test sessions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client advertises terminal_output_delta, stream command output only through that channel. Do not repeat live output in rawOutput at completion. Session history keeps its complete output for reconstruction.\n\nTracks IJAI-2376.