Use more specific interfaces than store.Interface - #986
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoAug 16, 2026
Merged
Conversation
This makes it clear(er) which methods of store.Interface are used in which paths.
Julian Gutierrez Oschmann (juli4n)
approved these changes
Aug 16, 2026
Julian Gutierrez Oschmann (juli4n)
merged commit Aug 16, 2026
e2f2b1e
into
agent-substrate:main
13 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it clear(er) which methods of store.Interface are used in which paths.
No functional changes
Julian Gutierrez Oschmann (@juli4n) Luiz Oliveira (@laoj2) as a first step towards splitting the validation logic out of the RPC layer and out of the storage layer. This at least gives us targets for what to pay attention to first.