oidcjwt: add tests for security checks and concurrent access - #983
Open
geyingqi (mowangdk) wants to merge 1 commit into
Open
oidcjwt: add tests for security checks and concurrent access#983geyingqi (mowangdk) wants to merge 1 commit into
geyingqi (mowangdk) wants to merge 1 commit into
Conversation
The Verifier.Verify method enforces several security invariants (audience match, subject required, time-binding validity, discovery issuer match) that had no direct test coverage. Add table-driven and standalone tests for each rejection path, plus a concurrent-access test to exercise the double-checked locking in key() under the race detector.
geyingqi (mowangdk)
marked this pull request as ready for review
August 16, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Verifier.Verify method enforces several security invariants (audience match, subject required, time-binding validity, discovery issuer match) that had no direct test coverage. Add table-driven and standalone tests for each rejection path, plus a concurrent-access test to exercise the double-checked locking in key() under the race detector.