fix(add-skill): enumerate and install skills under skills/ (was broken for all repos) - #866
Merged
aaronjmars merged 1 commit intoAug 10, 2026
Conversation
…n for all repos) bin/add-skill could never install anything from a repo using the standard skills/<slug>/SKILL.md layout: the discovery find used -maxdepth 2 (SKILL.md lives at depth 3) and the installer resolved sources as $REPO_DIR/<slug> instead of $REPO_DIR/skills/<slug>. Verified end-to-end after the fix: - bin/add-skill aeonfun/aeon tx-explain -> installs SKILL.md - bin/add-skill Autonomy-Labs-Tech/aeon taskmarket-delegate --branch feat/taskmarket-delegate-skill -> installs SKILL.md + scripts + tests Falls back to $REPO_DIR/<slug> for packs that keep skills at repo root.
Contributor
Author
|
Local gate verification for PR #866 (fix bin/add-skill):
CI check-runs invisible to GitHub API (0 check-runs). Local gate replication confirms fix works end-to-end. |
|
Triage: ACCEPTED — clean against the contribution rubric (scope ✓ / format n/a / originality n/a / size ✓). Small, well-scoped one-file fix with an end-to-end verification note in the PR body. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
bin/add-skillcannot install anything from a repo using the standardskills/<slug>/SKILL.mdlayout — the one used by this repo's own 74 skills:find "$REPO_DIR" -maxdepth 2 -name SKILL.mdnever matchesskills/<slug>/SKILL.md(depth 3) -> "No skills found in " for every repo.src="$REPO_DIR/$skill"misses theskills/subdir ->skip: '<skill>' not found in repo.Reproduced on
aeonfun/aeonmain (74 skills):bin/add-skill aeonfun/aeon tx-explainandbin/add-skill aeonfun/aeon --listboth fail.Fix
-maxdepth 2->-maxdepth 3(coversskills/<slug>/SKILL.md, keeps legacy flatter layouts).$REPO_DIR/skills/$skillfirst, fall back to$REPO_DIR/$skill.Verified (end-to-end)
bin/add-skill aeonfun/aeon tx-explain->Done: 1 installed(SKILL.md lands, aeon.yml entry present).bin/add-skill Autonomy-Labs-Tech/aeon taskmarket-delegate --branch <pr-branch>-> installed SKILL.md + scripts/taskmarket.js + tests/test-taskmarket.js; installed suite passes 6/6.