Back cdr : Endpoint to get total of validated payments - #1028
Open
Bombefire wants to merge 32 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
+ Coverage 84.94% 84.96% +0.01%
==========================================
Files 220 220
Lines 16378 16399 +21
==========================================
+ Hits 13912 13933 +21
Misses 2466 2466 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Luhmos
reviewed
Aug 16, 2026
armanddidierjean
force-pushed
the
total-purchase
branch
from
August 26, 2026 20:11
cfd70c4 to
dfd85eb
Compare
armanddidierjean
previously requested changes
Aug 26, 2026
Rotheem
reviewed
Sep 8, 2026
Bombefire
dismissed
armanddidierjean’s stale review
September 8, 2026 16:44
Implemented. How do you accept a change without dismissing it ?
Rotheem
reviewed
Sep 8, 2026
| headers={"Authorization": f"Bearer {token_admin}"}, | ||
| ) | ||
| assert response.status_code == 200 | ||
| assert response.json() == {"total_amounts": [{"name": "BDE", "total_amount": 5000}]} |
Member
There was a problem hiding this comment.
You should rather use
Suggested change
| assert response.json() == {"total_amounts": [{"name": "BDE", "total_amount": 5000}]} | |
| data = response.json() | |
| assert len(data["total_amounts"]) == 1 | |
| first_data = data["total_amounts"][0] | |
| assert first_data["name"] == "BDE" | |
| assert first_data["total_amount"] == 5000 |
| headers={"Authorization": f"Bearer {token_admin}"}, | ||
| ) | ||
| assert response.status_code == 200 | ||
| assert response.json() == {"total": 5000, "payment_type": "cash"} |
Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
Bombefire
force-pushed
the
total-purchase
branch
from
September 9, 2026 01:57
ac042cc to
5a6921e
Compare
Rotheem
approved these changes
Sep 11, 2026
|
|
||
| @module.router.get( | ||
| "/cdr/stats/payment_total/", | ||
| response_model=int, |
Member
There was a problem hiding this comment.
Please return a schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Adding the endpoint for Enceladus to have the total payment done in the CDR and have the total of purchase that have been validated by the sellers.
...
Issues/PR dependencies
A futur PR in Enceladus will come to make use of this endepoint
Issues to be resolved
Required PRs
Changes Made
Additional Notes
Classification
Type of Change
Impact & Scope
Testing
Documentation
"Docstrings#Inline comments