feat(aem-cloud-service): add guava-cache analyzer detector + expert skill - #326
Closed
bharat941 wants to merge 1 commit into
Closed
feat(aem-cloud-service): add guava-cache analyzer detector + expert skill#326bharat941 wants to merge 1 commit into
bharat941 wants to merge 1 commit into
Conversation
bharat941
requested review from
Himanich,
abhishekgarg18,
akankshajain18,
pkumargaddam and
rombert
as code owners
September 3, 2026 06:45
…kill Adds the guava-cache code-assessment pattern (Guava cache -> Caffeine on AEM CS): - GuavaCache detector: import-anchored on com.google.common.cache.* (Java-only), registered in Registry.all(); exact prefix avoids the micrometer GuavaCacheMetrics false positive. - guava-cache/ expert skill: SKILL.md (control plane) + recipe.md (C1 pom swap, C2 imports, C3 builder/API mapping, test generation). - Catalog row in patterns.md (low | ready | analyzer | guided) + Manual Pattern Hints routing row in code-assessment SKILL.md. - Fixtures (legacy guava / clean caffeine / micrometer guard) + run-tests.sh block. Analyzer suite: 109 PASS / 0 FAIL (incl. [wiring] + guava block).
bharat941
force-pushed
the
feat/guava-cache-code-assessment
branch
from
September 3, 2026 06:48
1cf39e8 to
e0d40c1
Compare
rombert
requested changes
Sep 3, 2026
rombert
left a comment
rombert
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @bharat941
Two main comments:
- If Caffeine the officially recommended replacement from Adobe? We have this article that references Guava but there is no mention of Caffeine.
- Please remove comments from fixtures that explain if they should be flagged or not, this is not expected in real codebases.
Contributor
Author
|
Superseded by #331, re-raised from a branch on adobe/skills (identical commits) now that write access is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the guava-cache code-assessment pattern — Guava cache (
com.google.common.cache.*) → Caffeine (com.github.benmanes.caffeine.cache.*) on AEM as a Cloud Service. Follows thereferences/adding-a-pattern.mdprocedure; the slugguava-cacheis wired into all four required places so the[wiring]test stays green.Changes
scripts/analyzer/detectors/GuavaCache.java, registered inRegistry.all(). Import-anchored oncom.google.common.cache.*(Java-only). Exact package prefix means theio.micrometer…GuavaCacheMetricsBPA false positive is not flagged.guava-cache/SKILL.md(control plane) +guava-cache/recipe.md(C1 pom swap, C2 imports, C3 builder/API mapping incl.getUnchecked→get,Callable→Function,RemovalNotification→3-arg; test generation).references/patterns.mdrow (low | ready | analyzer | guided) and Manual Pattern Hints row incode-assessment/SKILL.md.test/code-assessment/fixtures/guava-cache/(legacy guava / clean caffeine / micrometer guard) + a block inrun-tests.sh.Test Plan
run-tests.sh— 109 PASS / 0 FAIL (incl.[wiring]and the new[guava-cache]block). Detector flagscom.google.common.cache.*imports; does not flag Caffeine orGuavaCacheMetrics. End-to-end on a real legacy AEM project: analyzer detects → recipe transform applied → analyzer re-scan clean →mvn compileBUILD SUCCESS.