Skip to content

feat(migration): URC (Unsupported Run Modes Configuration) detection + safe reorder - #322

Open
Himanich wants to merge 15 commits into
mainfrom
feat/migration-urc-runmodes
Open

feat(migration): URC (Unsupported Run Modes Configuration) detection + safe reorder#322
Himanich wants to merge 15 commits into
mainfrom
feat/migration-urc-runmodes

Conversation

@Himanich

@Himanich Himanich commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds detection (and a safe, opt-in reorder fix) for URC — Unsupported Run Modes Configuration to the AEM-as-a-Cloud-Service migration skill, under the existing osgiConfig handling. AEMaaCS supports only an exact, ordered run-mode set; OSGi config.<runmode> / bundle install.<runmode> folders named with unsupported run modes (custom tokens, or valid tokens in the wrong order) silently have no effect when deployed. Adobe's Pattern Detector reports this as URC (subtype: unsupported.runmode).

Related Issue

Motivation and Context

How Has This Been Tested?

Unit suites + an env-gated real-config acceptance test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Himani Chauhan and others added 14 commits September 1, 2026 12:20
Himani Chauhan @claude
docs(migration): URC run-mode design spec
2ba6585 
Report-first (BPA subtype unsupported.runmode) with local run-mode folder
detection as fallback, kept under the osgiConfig pattern. Covers config.* and
install.* folders, enforces tier-before-env ordering, flag-only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
docs(migration): URC implementation plan
9e06deb 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
docs(migration): add safe URC auto-reorder fix (Task 6) to spec + plan
2913dee 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
docs(migration): URC fix emits git mv commands (read-only), not fs re…
29ace5f 
…names

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
docs(migration): align URC fix UX with Branch A/code-assessment apply…
c0e20e7 
… model

Read-only planner + skill-applied git mv on opt-in apply (like Phase 0), unsafe
items to handoff cleanup, developer reviews diff and commits. No copy-paste.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
docs(migration): fix stale planner JSDoc comment (skill applies on Br…
f32b8b5 
…anch A)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
feat(migration): URC run-mode folder validator with ordering rule
50ae774 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
feat(migration): local URC scanner over config.*/install.* folders
6f742f5 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
feat(migration): map BPA subtype unsupported.runmode to urc pattern
1c1c27a 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
feat(migration): BPA-first URC detection under osgiConfig with local …
ea3a05d 
…fallback

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
docs(migration): document URC detection (ordering rule, install scope…
9309267 
…, remediation)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
feat(migration): planner for safe URC reorders (skill-applied git mv …
d304c92 
…on apply)

Deterministic reorder of ordering-only run-mode folders (config.dev.author ->
config.author.dev). planRunmodeReorders is a read-only planner; the Branch A
apply runs the git mv itself and records it in the handoff. Unknown tokens,
duplicate tier/env, and collisions route to the handoff cleanup for a human.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
fix(migration): enrich BPA-sourced URC findings + document runmode_re…
40fb73e 
…orders handoff

BPA-sourced URC findings now carry the folder basename, reason, and runmode
(via validateRunmodeFolder on the JCR path) matching the local scanner's shape,
instead of a bare "unsupported.runmode" detail. Adds the runmode_reorders array
to the Phase 3 handoff schema example.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himani Chauhan @claude
fix(migration): URC review fixes — safety-net local scan, case-sensit…
8763a47 
…ive run modes

- BPA report with no URC rows now warns + runs the local scan (was silently
  treated as clean, masking on-disk unsupported folders; also closes the MCP
  masking path).
- Run-mode tokens are case-sensitive (config.Author.dev now flagged; the
  reorder planner no longer silently case-folds config.DEV.author).
- Flag malformed runmode folders (config., config..dev).
- Add MCP-path URC tests; document git mv command as display-only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tessl Plugin Lint

⚠️ edge-delivery-services — 2 warning(s) 
⚠ Skill 'code-review': SKILL.md is approximately 10352 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'figma-to-content': SKILL.md is approximately 14744 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.

✔ Plugin adobe/aem-edge-delivery-services@0.1.0 is valid
⚠️ app-management — 1 warning(s) 
⚠ Skill 'commerce-app-admin-ui': SKILL.md is approximately 5265 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.

✔ Plugin adobe/commerce-app-management@1.3.2 is valid

✅ app-migration — clean

✅ app-review — clean

✅ run-workflow — clean

⚠️ stardust — 9 warning(s) 
⚠ Skill 'extract': SKILL.md is approximately 9459 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'direct': SKILL.md is approximately 11694 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'prototype': SKILL.md is approximately 17875 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'migrate': SKILL.md is approximately 6375 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'uplift': SKILL.md is approximately 6515 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'audit': SKILL.md is approximately 5269 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'reskin': SKILL.md is approximately 5906 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'deploy': SKILL.md is approximately 36719 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.
⚠ Skill 'rollout': SKILL.md is approximately 6779 tokens (recommended maximum: 5000). Consider moving detailed content to separate reference files.

✔ Plugin adobe/stardust@0.18.1 is valid

✅ All 6 plugin(s) lint passed with 12 warning(s) total.

Updated by tessl-lint for commit eaf593b.

Himani Chauhan @claude
chore(migration): drop SDD spec/plan scaffolding from the branch
53a17a5 
These are Superpowers workflow artifacts (design spec + implementation plan),
not part of the shipped skill. Removing so they do not appear in the PR.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rombert
rombert approved these changes Sep 2, 2026
View reviewed changes

@rombert rombert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check if the tessl eval raises any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rombert rombert rombert approved these changes
@abhishekgarg18 abhishekgarg18 Awaiting requested review from abhishekgarg18 abhishekgarg18 is a code owner
@pkumargaddam pkumargaddam Awaiting requested review from pkumargaddam pkumargaddam is a code owner
@akankshajain18 akankshajain18 Awaiting requested review from akankshajain18 akankshajain18 is a code owner
@trieloff trieloff Awaiting requested review from trieloff

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Himanich @rombert