Skip to content

Fix data buffer character encoding (#20) - #23

Open
Baccega wants to merge 1 commit into
adobe:mainfrom
wirecube:main
Open

Fix data buffer character encoding (#20)#23
Baccega wants to merge 1 commit into
adobe:mainfrom
wirecube:main

Conversation

@Baccega

@Baccega Baccega commented Feb 23, 2023

Copy link
Copy Markdown

Description

This PR will change the character encoding of the data buffer from binary(latin1) to utf-8

Related Issue

#20

Motivation and Context

This change is required in order to make the proxy able to support characters like: 'Ö', that otherwise it would break into gibberish. More info on buffer character encoding here.

How Has This Been Tested?

I've tested this fix in my local aem dev server by adding text with: ö, ß, ü.

Screenshots (if appropriate):

Before:

image

After:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant