fix: avoid orphaning a final wrapped character - #239
Merged
tannewt merged 1 commit intoJul 27, 2026
Conversation
Signed-off-by: p1 <giridharpavan593@gmail.com>
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 29, 2026
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.11.9 from 3.11.8: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#127 from grgrant/Fix123 > Merge pull request adafruit/Adafruit_CircuitPython_GPS#126 from grgrant/issue124 Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 5.0.5 from 5.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#239 from giri256/fix/avoid-orphaned-final-character Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.5.0 from 3.4.20: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#79 from giri256/fix/continuous-servo-disable Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.12.1 from 1.12.0: > Merge pull request adafruit/Adafruit_CircuitPython_Register#61 from giri256/docs/alarm-date-limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226
When splitting an overlong word,
wrap_text_to_pixels()always reserved space for a continuation hyphen before testing the next character. On the final character, that could force a character that otherwise fit onto a new line and leave the previous line ending in an unnecessary hyphen.This reserves hyphen width only when characters remain after the one being tested. True continuations still keep their hyphen, while the final character can use the available line width.
Regression example at width 4:
['abc-', 'def-', 'g']['abc-', 'defg']Verification:
python -m compileall -q adafruit_display_textruff format --check adafruit_display_text/__init__.pyruff check adafruit_display_text/__init__.py