Add CI success aggregator job for branch protection#212
Closed
Add CI success aggregator job for branch protection#212
Conversation
Adds a single `CI success` job that depends on all matrix jobs and the coverage job. Branch protection can then require just this one check instead of enumerating every matrix combination, so adding or removing a Ruby/Rails/ActiveAdmin version does not require updating protection rules.
Member
Author
|
Superseded — we dropped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a single
CI successaggregator job that depends on every matrix row (test) plus thecoveragejob.Why
masterbranch protection still requires the stalecontinuous-integration/travis-cicheck (a holdover from before we switched to GitHub Actions), which never reports — so PRs appear to wait on CI forever.Requiring individual GitHub Actions matrix rows in branch protection is brittle: any time we add/remove a Ruby, Rails, or ActiveAdmin version, we also have to update the protection rule, and missed updates silently break PR merging.
With this aggregator job, branch protection only needs to require one check:
CI success. Matrix changes no longer require touching the protection rule.Follow-up (manual)
After this is merged, update
masterbranch protection to:continuous-integration/travis-ciCI successTest plan
ci-successjob is added withneeds: [test, coverage]andif: always()so it runs even if an upstream job failsresultso the aggregator fails if any matrix row or coverage run fails