Skip to content

[kb1m8s] Failed example 5 does not fail the rule#2413

Open
giacomo-petri wants to merge 1 commit intodevelopfrom
giacomo-petri-patch-global-properties-prohib-attrs
Open

[kb1m8s] Failed example 5 does not fail the rule#2413
giacomo-petri wants to merge 1 commit intodevelopfrom
giacomo-petri-patch-global-properties-prohib-attrs

Conversation

@giacomo-petri
Copy link
Copy Markdown
Collaborator

@giacomo-petri giacomo-petri commented May 7, 2026

In ARIA global properties not used where prohibited, Failed example 5 does not violate the rule. aria-brailleroledescription is not prohibited for elements with the none role, but it is prohibited for elements with the generic role, so I've updated the example by replacing "none" with "generic".

Closes issue(s): #2386

Need for Call for Review:
This will require a 1 week Call for Review


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@giacomo-petri giacomo-petri self-assigned this May 7, 2026
@giacomo-petri giacomo-petri added the Rule Update Use this label for an existing rule that is being updated label May 7, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 7, 2026

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 2cd37ec
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/69fc6c1acfc1310008712cea
😎 Deploy Preview https://deploy-preview-2413--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants