Skip to content

[IMP] contract_sale_generation: link sale orders to their contract - #6

Open
StephaneMangin wants to merge 2 commits into
19.0-mig-rvi-contract_sale_generationfrom
19.0-imp-contract_sale_generation-recurring_sale_hook
Open

StephaneMangin wants to merge 2 commits into
19.0-mig-rvi-contract_sale_generationfrom
19.0-imp-contract_sale_generation-recurring_sale_hook

Conversation

@StephaneMangin

@StephaneMangin StephaneMangin commented Oct 27, 2026 •

Copy link
Copy Markdown
  • add the contract on the generated sale orders
  • find related sales and auto confirmation from it
  • REF to increase extendability

@StephaneMangin
StephaneMangin force-pushed the 19.0-imp-contract_sale_generation-recurring_sale_hook branch from 1bedeaf to 1ca3bad Compare October 27, 2026 11:47
@StephaneMangin StephaneMangin changed the title [IMP] contract_sale_generation: recurring sale values per contract [IMP] contract_sale_generation: link sale orders to their contract Oct 27, 2026
@StephaneMangin
StephaneMangin force-pushed the 19.0-imp-contract_sale_generation-recurring_sale_hook branch from 1ca3bad to 559d07b Compare October 27, 2026 12:11
@acsone acsone deleted a comment from codecov-commenter Oct 27, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (19.0-mig-rvi-contract_sale_generation@4d9eb81). Learn more about missing BASE report.

Additional details and impacted files
@@                           Coverage Diff                            @@
##             19.0-mig-rvi-contract_sale_generation       #6   +/-   ##
========================================================================
  Coverage                                         ?   97.40%           
========================================================================
  Files                                            ?      120           
  Lines                                            ?     4668           
  Branches                                         ?      386           
========================================================================
  Hits                                             ?     4547           
  Misses                                           ?       58           
  Partials                                         ?       63           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StephaneMangin
StephaneMangin force-pushed the 19.0-imp-contract_sale_generation-recurring_sale_hook branch from 559d07b to 101ec77 Compare October 27, 2026 14:17
- add a hook to prepare the sale values of one contract
- add the contract on the generated sale orders
- find related sales and auto confirmation from it
@StephaneMangin
StephaneMangin force-pushed the 19.0-imp-contract_sale_generation-recurring_sale_hook branch from 101ec77 to 75faef5 Compare October 27, 2026 14:19
Comment on lines +7 to +10
<xpath
expr="//group[@name='recurring_type']/field[@name='generation_type']"
position="after"
>

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue with placement otherwize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants