improve: deploy new Tempo beacon implementation - #1509
Conversation
tbwebb22
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42810c75b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Variable memory v = config.get("usdcOverride"); | ||
| if (v.ty.kind == TypeKind.Address) return v.toAddress(); |
There was a problem hiding this comment.
When this override is used on Tempo, CheckCounterfactualDeployments still computes expected USDC via its local _getUsdc() from .USDC.<chainId> only, and generated/constants.json has no .USDC.4217. After the live Tempo beacon is upgraded to this implementation, that verification script will compare beacon.usdc() (0x20C0000000000000000000000000000000000000) and usdcSpokePoolMaxExecutionFee() (2000000) against zero, so the advertised live-deployment check reports a false failure. Please update that script to use the same override-aware resolver before relying on usdcOverride.
Useful? React with 👍 / 👎.
1 participant
No description provided.