Skip to content

chore: Deploy SpokePoolPeriphery to RobinHood - #1507

Merged
fusmanii merged 2 commits into
masterfrom
faisal/deploy-new-periphery-to-robinhood
Jul 30, 2026
Merged

chore: Deploy SpokePoolPeriphery to RobinHood#1507
fusmanii merged 2 commits into
masterfrom
faisal/deploy-new-periphery-to-robinhood

Conversation

@fusmanii

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58f1e42552

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread foundry.toml
lint_on_build = false

[rpc_endpoints]
avalanche = "${NODE_URL_43114}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Obtain approval before adding RPC endpoints

If explicit approval was not obtained for this deployment change, adding the Avalanche and Robinhood RPC aliases violates the repository requirement that foundry.toml not be modified without asking; obtain that approval or revert these entries before merging.

AGENTS.md reference: AGENTS.md:L150-L152

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@fusmanii
fusmanii requested review from grasphoper and tbwebb22 July 30, 2026 16:44
Comment thread src/consts.ts Outdated
permit2: "0x000000000022D473030F116dDEE9F6B43aC78BA3",
},
[CHAIN_IDs.ROBINHOOD]: {
helios: "0x9b4A302A548c7e313c2b74C461db7b84d3074A84",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We deploy helios contracts from this repo now. Why do we need to keep these in consts?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, we don't. removed: 7ccd241

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
@fusmanii
fusmanii requested a review from grasphoper July 30, 2026 17:25
@fusmanii
fusmanii merged commit a382fdf into master Jul 30, 2026
9 checks passed
@fusmanii
fusmanii deleted the faisal/deploy-new-periphery-to-robinhood branch July 30, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants