Repository navigation
Move prism to upstream master, with its new backends and flags - #9
Merged
Merged
Conversation
…no speech backends and the screen reader, speech engine and explicit selection flags
…de signing checks call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the prism submodule from 94329eb to upstream master (291db9f, prism 0.18.3), 101 commits on.
The C API is unchanged apart from additions: every function keeps its signature (they gain
noexceptin C++), andPRISM_CONFIG_VERSIONandPRISM_PLUGIN_ABI_VERSIONare still 4 and 1. The additions are bound inprism-sysand exposed inprismer:GDK_SPEECH(Microsoft GDK speech, built only when the GDK's headers are present),CLIPBOARDandNO_SPEECH.IS_SCREEN_READER,IS_SPEECH_ENGINEandREQUIRES_EXPLICIT_SELECTION.A behaviour change from upstream: UIA now reports
REQUIRES_EXPLICIT_SELECTION, socreate_bestno longer picks it. An application that wants Narrator has to ask for UIA by ID or name. Clipboard and No Speech are explicit-only too.Upstream now links CoreServices and Security on macOS for its code-signing checks, so a static build links them too, and the README's list for Xcode projects says so. The first CI run failed on exactly that.
Upstream also moved Orca, Spiel and power management to raw D-Bus. The static Linux link reads its pkg-config modules from the
prism-config.cmakeprism installs, so it follows that change by itself; CI's static Linux jobs check it.Checked on Windows x64: tests and clippy pass, and a probe listing every backend showed the new flags as documented. Speaking through No Speech worked, and
create_beststill picks NVDA when it's running.