Repository navigation
Release 0.9.2: tested on older MATLAB and EEGLAB releases - #26
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQCvXRAV17aYyMFUdXAzvb
…nent RMS scaling EEGLAB 2024.2.1 rescales each component to RMS microvolts (option_scaleicarms) on one of the two paths; the test now checks what it was written for, the 1e6 volts -> microvolts factor, and stays exact about everything else. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQCvXRAV17aYyMFUdXAzvb
…s supports for them; time out after an hour Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQCvXRAV17aYyMFUdXAzvb
…lel pool on MATLAB before R2022b; drop R2022b from the compatibility matrix Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQCvXRAV17aYyMFUdXAzvb
abwoo
changed the title
abwoo
marked this pull request as ready for review
October 6, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Pamuk · project thread
Before: the tests ran only on the latest MATLAB and the newest EEGLAB, so it was unknown whether PipeCompare works for the many users on older versions. With Parallel checked, MATLAB releases before R2022b fell back to running one pipeline at a time without saying so.
After: a compatibility workflow runs the full suite (177 tests) on MATLAB R2021b, R2023b, R2024b and the latest release with EEGLAB 2026.0.0, and on the latest MATLAB with EEGLAB 2024.2.1 and 2025.1.0. All pass. The README states the tested versions, and parallel execution uses the pool profile older releases have.
How:
.github/workflows/compat.yml: the matrix above (R2021b on Ubuntu 22.04, the newest Ubuntu MathWorks supports for it; one-hour timeout).Executor.canParallel: tries theProcessesprofile, thenlocal.test_engine/testVoltConversionScriptScalesIcaLikeTheSearch: EEGLAB 2024 and 2025 rescale each ICA component to RMS µV on one of the two paths (EEGLAB'soption_scaleicarms); the weights now must agree up to that per-row scale, and a missing 1e6 V→µV factor still fails it. The cleaned data and the objectives are still compared exactly.uialert(on Ubuntu 22.04 and 24.04). The README says R2022b is untested.🤖 Generated with Claude Code
https://claude.ai/code/session_01UQCvXRAV17aYyMFUdXAzvb