feat(financial-events): add ShipmentSettleEventList for DD+7 delivery date policy - #944
Merged
abuzuhri merged 1 commit intoJun 11, 2026
Conversation
… date policy Amazon returns a ShipmentSettleEventList in the v0 FinancialEvents response for orders subject to the Delivery Date Policy (DD+7). Adding the property to the FinancialEvents model ensures these settle events are deserialised rather than silently discarded.
|
abuzuhri
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Amazon returns a
ShipmentSettleEventListin the v0 Finances APIFinancialEventsresponse for orders subject to the Delivery Date Policy (DD+7). This property was missing from theFinancialEventsmodel, causing those settle events to be silently discarded during deserialisation.Test plan
dotnet build)ShipmentSettleEventListis populated when deserialising aFinancialEventsresponse containing DD+7 settle events