chore: remove the dead hook-plugin_loader.py - #410
Merged
Conversation
The hook targets a module named plugin_loader, but every core imports scripts.plugin_loader, so the bare name never enters any import graph and PyInstaller never consults the hook. It has been inert since the loader moved into scripts/, and its own TODO comment predicted the break. The hidden imports it was meant to provide are covered explicitly in the spec files since the frozen-build fixes landed. Verified where a local frozen build is available: rebuilding the macOS CLI without the hook produces identical results (same module count, clean empty-input run). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dead PyInstaller hook. It targets a module named plugin_loader, but this core imports scripts.plugin_loader, so the bare name never enters any import graph and PyInstaller never consults the hook — it has been inert since the loader moved into scripts/, and its own TODO comment predicted the break. The hidden imports it was meant to provide are declared explicitly in the spec files since the frozen-build fixes landed across the cores.
Where the specs carried a comment referencing the hook, the comment is trimmed in the same commit.
Verification: rebuilding the frozen macOS CLI from this branch produces identical results to before the removal (same module count, clean empty-input run). For iLEAPP, a test_builds dispatch after merge is the equivalent check.
Part of the cross-core CI leveling pass.
🤖 Generated with Claude Code