fix: collect the packages artifacts import into frozen builds - #407
Merged
Conversation
Same defect class ALEAPP PR #1097 fixed: artifacts are bundled as data files and imported from disk at runtime, so PyInstaller never sees their imports, and hook-plugin_loader.py targets a bare plugin_loader module that moved to scripts.plugin_loader, so it never fires. The hand-kept hiddenimports lists were missing bs4 and every leapp_functions submodule artifacts import, the non-Windows specs were additionally missing simplekml, and pdfminer (imported lazily by the Kik artifact with a graceful fallback) was absent everywhere, so frozen builds silently lost a capability dev runs have. All six specs now collect leapp_functions, PIL and pdfminer wholesale and add bs4, with simplekml leveled into the four specs missing it. Verified locally by building rleapp_macOS.spec on Python 3.14 and running the frozen CLI end to end: 385 modules loaded, exit 0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight for the test_builds workflow port, fixing the same frozen-build defect class ALEAPP #1097 fixed: artifacts are bundled as data files and imported from disk at runtime, so PyInstaller's import-graph analysis never sees what they import, and the existing hook-plugin_loader.py never fires (it targets a bare plugin_loader module; the loader moved to scripts.plugin_loader).
What was missing, found by enumerating every third-party import across scripts/ against the spec lists:
All six specs now collect leapp_functions, PIL and pdfminer wholesale and add bs4. Verified locally: built rleapp_macOS.spec on Python 3.14 with these changes and ran the frozen CLI end to end (--help plus an empty-input run): 385 modules loaded, exit 0, no import errors.
🤖 Generated with Claude Code