Skip to content

fix: make sure the delivered LAVA database opens from read-only media #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abrignoni wants to merge 1 commit into from
Closed

fix: make sure the delivered LAVA database opens from read-only media #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions scripts/lavafuncs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,5 +682,19 @@ def lava_finalize_output(output_path):
with open(os.path.join(output_path, lava_json_name), 'w', encoding='utf-8') as f:
json.dump(lava_data, f, indent=4)

# A database left in WAL mode cannot be opened from read-only media: SQLite
# must create a -shm file to read one, and the LAVA viewer opens the report
# database with OPEN_READONLY. Checkpointing and returning to the delete
# journal guarantees the delivered .db is complete and standalone, with no
# -wal/-shm sidecars to lose when the report folder is copied or zipped.
# This normalises whatever mode the connection ended up in; nothing here
# enables WAL.
try:
if lava_db.execute('PRAGMA journal_mode').fetchone()[0].lower() == 'wal':
lava_db.execute('PRAGMA wal_checkpoint(TRUNCATE)')
lava_db.execute('PRAGMA journal_mode=DELETE')
except sqlite3.Error:
pass

# Close the SQLite database
lava_db.close()
Loading