Skip to content

Apply sign-in checks to external login providers - #26305

Merged
EngincanV merged 2 commits into
rel-10.7from
maliming/external-login-sign-in-checks
Oct 20, 2026
Merged

EngincanV merged 2 commits into
rel-10.7from
maliming/external-login-sign-in-checks

Conversation

@maliming

Copy link
Copy Markdown
Member

Apply the sign-in checks (active, confirmation, lockout, password change) to users authenticated by an IExternalLoginProvider in AbpSignInManager, and skip disabled providers.
Add AbpSignInManager.CallPreSignInCheckWithoutPasswordAsync and show the related messages on the login and register pages and the password grant of OpenIddict and IdentityServer.

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.97908% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.10%. Comparing base (06af580) to head (0a0e117).
⚠️ Report is 1 commits behind head on rel-10.7.

Files with missing lines Patch % Lines
...ty.Domain/Volo/Abp/Identity/IdentityUserManager.cs 62.50% 0 Missing and 3 partials ⚠️
...Pages/Account/IdentityServerSupportedLoginModel.cs 84.61% 0 Missing and 2 partials ⚠️
...Volo.Abp.Account.Web/Pages/Account/Login.cshtml.cs 90.90% 0 Missing and 2 partials ⚠️
...o.Abp.Account.Web/Pages/Account/Register.cshtml.cs 86.66% 2 Missing ⚠️
...re/Volo/Abp/Identity/AspNetCore/AbpSignInResult.cs 90.90% 0 Missing and 1 partial ⚠️
...spNetIdentity/AbpResourceOwnerPasswordValidator.cs 98.46% 0 Missing and 1 partial ⚠️
...OpenIddict/Controllers/TokenController.Password.cs 98.52% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           rel-10.7   #26305      +/-   ##
============================================
- Coverage     49.13%   49.10%   -0.03%     
============================================
  Files          3942     3991      +49     
  Lines        137817   139652    +1835     
  Branches      10594    10836     +242     
============================================
+ Hits          67713    68579     +866     
- Misses        68084    69017     +933     
- Partials       2020     2056      +36     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EngincanV
EngincanV merged commit 59b04c4 into rel-10.7 Oct 20, 2026
4 of 5 checks passed
@EngincanV
EngincanV deleted the maliming/external-login-sign-in-checks branch October 20, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants