Repository navigation
Auto-merge forward rel-10.7 → dev - #26300
Merged
Merged
Conversation
- Skip SignalR hub requests in `AbpUnitOfWorkMiddleware` - Don't begin a completed or disposed reservation in `TryBeginReserved`
Resolve #26259 `UseUnitOfWork()` completes the request unit of work after the rest of the pipeline. If the action returned a body, the response has already started by then. So when the commit or a unit of work event handler fails, the client still gets `200 OK` with the success body, and the data is not saved. The startup templates will use `UseAbpExceptionHandling()` instead. Then the MVC action and page filters complete the unit of work before the result is written, and a failure returns an error. The unit of work document now explains this, the middleware options and their limits. Also fixed: - A SignalR hub connection kept one unit of work for its whole lifetime, so writes in hub calls could be lost when it closed. The middleware now skips hub requests. A hub method that queries an `IQueryable` directly needs its own unit of work. - `TryBeginReserved` no longer reuses a reservation that was already completed or disposed, like one a background task sees after its request ends. Such work now starts a new unit of work.
…d/rel-10.7-to-dev-90
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated forward merge of
rel-10.7intodev.