Repository navigation
Keep the 10.6.2 npm dependency update on the 10.6 line - #26271
Merged
Merged
Conversation
update-gulp followed the latest dist-tag and rewrote @abp dependencies to 10.7.0 during the patch release. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Prereleases can still cross minor lines, and registry lookup failures fall back to the unsafe latest target.
1 open finding
What changed in this PR
Keeps 10.6 maintenance releases aligned with the 10.6 npm dependency line.
Changes:
- Restores internal
@abpdependencies to 10.6.2 while retaining LeptonX 5.6.2. - Selects ncu’s patch target for older maintenance lines.
- Passes the release version into
update-gulp.
| File | Description |
|---|---|
templates/module/aspnet-core/host/MyCompanyName.MyProjectName.Web.Unified/package.json |
Pins Basic Theme to 10.6.2. |
templates/module/aspnet-core/host/MyCompanyName.MyProjectName.Web.Host/package.json |
Pins Basic Theme to 10.6.2. |
templates/module/aspnet-core/host/MyCompanyName.MyProjectName.Blazor.Server.Host/package.json |
Pins Blazor host dependencies. |
templates/module/aspnet-core/host/MyCompanyName.MyProjectName.AuthServer/package.json |
Pins AuthServer theme dependency. |
templates/module/angular/projects/my-project-name/package.json |
Restores Angular peer versions. |
templates/module/angular/package.json |
Restores module Angular dependencies. |
templates/app/angular/package.json |
Restores layered app dependencies. |
templates/app-nolayers/angular/package.json |
Restores no-layers dependencies. |
npm/update-gulp.js |
Adds release-aware ncu targeting. |
npm/publish-ng.ps1 |
Supplies the publishing version. |
npm/packs/zxcvbn/package.json |
Pins internal dependency. |
npm/packs/virtual-file-explorer/package.json |
Pins internal dependencies. |
npm/packs/vee-validate/package.json |
Pins internal dependency. |
npm/packs/uppy/package.json |
Pins internal dependency. |
npm/packs/tui-editor/package.json |
Pins internal dependencies. |
npm/packs/toastr/package.json |
Pins internal dependency. |
npm/packs/timeago/package.json |
Pins internal dependency. |
npm/packs/sweetalert2/package.json |
Pins internal dependency. |
npm/packs/star-rating-svg/package.json |
Pins internal dependency. |
npm/packs/signalr/package.json |
Pins internal dependency. |
npm/packs/select2/package.json |
Pins internal dependency. |
npm/packs/qrcode/package.json |
Pins internal dependency. |
npm/packs/prismjs/package.json |
Pins internal dependencies. |
npm/packs/popper.js/package.json |
Pins internal dependency. |
npm/packs/owl.carousel/package.json |
Pins internal dependency. |
npm/packs/markdown-it/package.json |
Pins internal dependency. |
npm/packs/malihu-custom-scrollbar-plugin/package.json |
Pins internal dependency. |
npm/packs/luxon/package.json |
Pins internal dependency. |
npm/packs/lodash/package.json |
Pins internal dependency. |
npm/packs/jstree/package.json |
Pins internal dependency. |
npm/packs/jquery/package.json |
Pins internal dependency. |
npm/packs/jquery-validation/package.json |
Pins internal dependency. |
npm/packs/jquery-validation-unobtrusive/package.json |
Pins internal dependency. |
npm/packs/jquery-form/package.json |
Pins internal dependency. |
npm/packs/highlight.js/package.json |
Pins internal dependency. |
npm/packs/font-awesome/package.json |
Pins internal dependency. |
npm/packs/docs/package.json |
Pins documentation pack dependencies. |
npm/packs/datatables.net/package.json |
Pins internal dependency. |
npm/packs/datatables.net-bs5/package.json |
Pins internal dependency. |
npm/packs/datatables.net-bs4/package.json |
Pins internal dependency. |
npm/packs/cropperjs/package.json |
Pins internal dependency. |
npm/packs/core/package.json |
Pins utilities dependency. |
npm/packs/codemirror/package.json |
Pins core dependency. |
npm/packs/cms-kit/package.json |
Pins CMS Kit dependencies. |
npm/packs/cms-kit.public/package.json |
Pins public CMS dependencies. |
npm/packs/cms-kit.admin/package.json |
Pins admin CMS dependencies. |
npm/packs/clipboard/package.json |
Pins core dependency. |
npm/packs/bootstrap/package.json |
Pins internal dependencies. |
npm/packs/bootstrap-daterangepicker/package.json |
Pins Moment dependency. |
npm/packs/blogging/package.json |
Pins blogging dependencies. |
npm/packs/aspnetcore.mvc.ui.theme.shared/package.json |
Pins shared theme dependencies. |
npm/packs/aspnetcore.mvc.ui.theme.basic/package.json |
Pins shared theme dependency. |
npm/packs/aspnetcore.components.server.theming/package.json |
Pins theming dependencies. |
npm/packs/aspnetcore.components.server.basictheme/package.json |
Pins server theming dependency. |
npm/packs/anchor-js/package.json |
Pins core dependency. |
npm/ng-packs/packages/theme-shared/package.json |
Pins Angular core dependency. |
npm/ng-packs/packages/theme-basic/package.json |
Pins Basic Theme dependencies. |
npm/ng-packs/packages/tenant-management/package.json |
Pins tenant dependencies. |
npm/ng-packs/packages/setting-management/package.json |
Pins setting dependencies. |
npm/ng-packs/packages/permission-management/package.json |
Pins shared theme dependency. |
npm/ng-packs/packages/oauth/package.json |
Pins OAuth dependencies. |
npm/ng-packs/packages/identity/package.json |
Pins identity dependencies. |
npm/ng-packs/packages/feature-management/package.json |
Pins shared theme dependency. |
npm/ng-packs/packages/core/package.json |
Pins utilities dependency. |
npm/ng-packs/packages/components/package.json |
Restores peer minimum versions. |
npm/ng-packs/packages/cms-kit/package.json |
Pins Angular CMS dependencies. |
npm/ng-packs/packages/account/package.json |
Pins account dependencies. |
npm/ng-packs/packages/account-core/package.json |
Pins account-core dependencies. |
npm/ng-packs/package.json |
Pins workspace tooling dependencies. |
modules/virtual-file-explorer/app/package.json |
Pins demo app dependencies. |
modules/setting-management/app/Volo.Abp.SettingManagement.DemoApp/package.json |
Pins demo theme dependency. |
modules/openiddict/app/OpenIddict.Demo.Server/package.json |
Pins demo theme dependency. |
modules/openiddict/app/angular/package.json |
Pins OpenIddict Angular dependencies. |
modules/docs/app/VoloDocs.Web/package.json |
Pins documentation app dependencies. |
modules/cms-kit/host/Volo.CmsKit.Web.Unified/package.json |
Pins unified CMS dependencies. |
modules/cms-kit/host/Volo.CmsKit.Web.Host/package.json |
Pins CMS host theme. |
modules/cms-kit/host/Volo.CmsKit.IdentityServer/package.json |
Pins IdentityServer theme. |
modules/cms-kit/angular/projects/cms-kit/package.json |
Restores CMS peer minimums. |
modules/cms-kit/angular/package.json |
Pins CMS Angular dependencies. |
modules/client-simulation/demo/Volo.ClientSimulation.Demo/package.json |
Pins demo theme dependency. |
modules/blogging/app/Volo.BloggingTestApp/package.json |
Pins blogging app dependencies. |
modules/basic-theme/test/Volo.Abp.AspNetCore.Mvc.UI.Theme.Basic.Demo/package.json |
Pins Basic Theme demo dependencies. |
modules/basic-theme/test/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.Demo/package.json |
Pins Bootstrap demo dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+60
to
+61
| if (program.prerelease) { | ||
| return ' --target newest'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@abpdependency versions to10.7.0becauseupdate-gulpfollows the npmlatestdist-tag.--target patch) when the release version is older thanlatest. A release that is itselflateststill moves forward.package.jsondependency versions from10.7.0to10.6.2. LeptonX stays at5.6.2.Test plan
@abp/*dependencies in packs, ng-packs, templates, and module apps are10.6.2, and@abp/ng.theme.lepton-xis still~5.6.2.yarn update-gulpdoes not move those dependencies to10.7.x.Made with Cursor