Repository navigation
Fix feature toggle cascade when group display name differs from name - #26241
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes consistently align tab selection with feature-map keys while preserving display labels.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes feature-toggle cascading by using group names consistently for tab selection and feature lookup.
Changes:
- Uses
group.namefor selection state, tabs, and panels. - Preserves display names in visible headings.
| File | Description |
|---|---|
| npm/ng-packs/packages/feature-management/src/lib/components/feature-management/feature-management.component.ts | Aligns selection state and feature lookup keys. |
| npm/ng-packs/packages/feature-management/src/lib/components/feature-management/feature-management.component.html | Updates tab bindings while preserving display labels. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sumeyyeKurtulus
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature management modal keyed the selected tab by group display name, but
features()is keyed by group name. SogetCurrentGroup()returned an empty list and checking a child or unchecking a parent did nothing for groups likeSettingManagementor any localized group name. The tabs now usegroup.nameas their value.https://abp.io/support/questions/10906