Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The localized fix includes regression coverage and has no identified blocking issues; tests were not executed.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes disabled-state rendering for OnPush components extending AbstractNgModelComponent.
Changes:
- Calls
markForCheck()after updating the disabled state. - Adds regression coverage for disabling and enabling a form control.
| File | Description |
|---|---|
| npm/ng-packs/packages/core/src/lib/tests/ng-model.component.spec.ts | Tests both disabled-state transitions with OnPush. |
| npm/ng-packs/packages/core/src/lib/abstracts/ng-model.component.ts | Marks the view for checking after disabled-state changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Hello @maliming Thank you for your fix. The support report matches the 10.6.1 bug: an effect only copied This fix here https://github.com/volosoft/volo/pull/22983 closes that gap. Lookups/pickers go through This update only adds For this reason, I am closing this PR. |
setDisabledStatenow callsmarkForCheck(), so OnPush components extendingAbstractNgModelComponentrefresh when the form control is disabled or enabled.